- Sheets: CSV export and save support, Excel-matching data validation - Docs: image, shape, WordArt, and chart rendering fixes - Slides: downloadable font catalog with a missing-font banner - Slides: better AI text layout and a speaker-notes tool Co-authored-by: GenOffice <merrick-2002@users.noreply.github.com>
227 lines
8.8 KiB
TypeScript
227 lines
8.8 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
||
|
||
import {
|
||
decimalRoundForPattern,
|
||
expandAsteriskFill,
|
||
exponentialDecimalRepair,
|
||
fixFormattedValue,
|
||
formatGeneral,
|
||
generalCharBudget,
|
||
yenLiteralDisplay,
|
||
} from '../src/renderer/numfmt-fix'
|
||
|
||
const NBSP = ' '
|
||
|
||
describe('expandAsteriskFill', () => {
|
||
const NBSP_CHAR = ' '
|
||
const ACCOUNTING = '_("$"* #,##0.00_);_("$"* \\(#,##0.00\\);_("$"* "-"??_);_(@_)'
|
||
// 1px per char keeps the arithmetic readable: available = width - 5.
|
||
const measure = (text: string) => text.length
|
||
|
||
it('pins the currency symbol left with an NBSP run to the column edge', () => {
|
||
const text = expandAsteriskFill(ACCOUNTING, 1, 25, measure)
|
||
// Prefix "<nbsp>$" + fill + "1.00<nbsp>" fills the 20px budget.
|
||
expect(text).toBe(`${NBSP_CHAR}$${NBSP_CHAR.repeat(13)}1.00${NBSP_CHAR}`)
|
||
})
|
||
|
||
it('fills the negative and zero sections at their own prefixes', () => {
|
||
expect(expandAsteriskFill(ACCOUNTING, -1, 25, measure)).toBe(
|
||
`${NBSP_CHAR}$${NBSP_CHAR.repeat(12)}(1.00)`,
|
||
)
|
||
const zero = expandAsteriskFill(ACCOUNTING, 0, 25, measure)
|
||
expect(zero?.startsWith(`${NBSP_CHAR}$${NBSP_CHAR}`)).toBe(true)
|
||
})
|
||
|
||
it('returns null without a fill or when nothing fits', () => {
|
||
expect(expandAsteriskFill('#,##0.00', 1, 25, measure)).toBeNull()
|
||
expect(expandAsteriskFill(ACCOUNTING, 1, 5, measure)).toBeNull()
|
||
})
|
||
|
||
it('matches escaped literal spaces before the fill (numfmt renders them NBSP)', () => {
|
||
const escapedSpace = '_("$"\\ * #,##0_);_("$"\\ * \\(#,##0\\);_("$"\\ * "-"_);_(@_)'
|
||
const text = expandAsteriskFill(escapedSpace, 683638, 30, measure)
|
||
expect(text).toBe(`${NBSP_CHAR}$${NBSP_CHAR}${NBSP_CHAR.repeat(14)}683,638${NBSP_CHAR}`)
|
||
})
|
||
})
|
||
|
||
describe('yenLiteralDisplay', () => {
|
||
const JIS_YEN = '"\\"#,##0'
|
||
|
||
it('renders the JIS 0x5C literal as yen for Japanese fonts', () => {
|
||
expect(yenLiteralDisplay(JIS_YEN, '\\1,275,730', 'Meiryo')).toBe('¥1,275,730')
|
||
expect(yenLiteralDisplay(JIS_YEN, '\\5', 'MS Pゴシック')).toBe('¥5')
|
||
expect(yenLiteralDisplay(JIS_YEN, '\\5', 'Yu Gothic')).toBe('¥5')
|
||
})
|
||
|
||
it('honors an explicit ja locale tag without a ja font', () => {
|
||
expect(yenLiteralDisplay('[$-411]"\\"#,##0', '\\5', 'Calibri')).toBe('¥5')
|
||
})
|
||
|
||
it('leaves non-Japanese contexts and other patterns alone', () => {
|
||
expect(yenLiteralDisplay(JIS_YEN, '\\5', 'Calibri')).toBeNull()
|
||
expect(yenLiteralDisplay(JIS_YEN, '\\5', undefined)).toBeNull()
|
||
expect(yenLiteralDisplay('#,##0', '5', 'Meiryo')).toBeNull()
|
||
})
|
||
})
|
||
|
||
describe('exponentialDecimalRepair', () => {
|
||
it('rebuilds tiny values numfmt mangles under fixed-decimal patterns', () => {
|
||
// numfmt renders these as "0.87e-800000" / all zeros.
|
||
expect(exponentialDecimalRepair('0.0000000000', 1.8744045912597986e-8)).toBe('0.0000000187')
|
||
expect(exponentialDecimalRepair('0.0000000000', 1e-7)).toBe('0.0000001000')
|
||
expect(exponentialDecimalRepair('0.0000000000', -9.99e-7)).toBe('-0.0000009990')
|
||
})
|
||
|
||
it('handles grouped, percent, and huge values', () => {
|
||
expect(exponentialDecimalRepair('#,##0.00', 1.23e21)).toBe('1,230,000,000,000,000,000,000.00')
|
||
expect(exponentialDecimalRepair('0.00000000%', 1.87e-8)).toBe('0.00000187%')
|
||
})
|
||
|
||
it('leaves non-exponential values and fancy patterns alone', () => {
|
||
expect(exponentialDecimalRepair('0.0000000000', 0.123)).toBeNull()
|
||
expect(exponentialDecimalRepair('0.00E+00', 1.87e-8)).toBeNull()
|
||
expect(exponentialDecimalRepair('"$"0.0000000000', 1.87e-8)).toBeNull()
|
||
expect(exponentialDecimalRepair('0.0#', 1.87e-8)).toBeNull()
|
||
})
|
||
|
||
it('bails on divide-by-1000 scaling commas', () => {
|
||
expect(exponentialDecimalRepair('0,.00', 1.23e21)).toBeNull()
|
||
expect(exponentialDecimalRepair('#,##0,.00', 1.23e21)).toBeNull()
|
||
expect(exponentialDecimalRepair('0,000.00', 1.23e21)).toBeNull()
|
||
})
|
||
|
||
it('flows through fixFormattedValue', () => {
|
||
expect(fixFormattedValue('0.0000000000', 1.8744045912597986e-8, '0.87e-800000')).toBe(
|
||
'0.0000000187',
|
||
)
|
||
})
|
||
})
|
||
|
||
describe('fixFormattedValue — empty sections', () => {
|
||
it('renders 0 as empty when the zero section is empty', () => {
|
||
expect(fixFormattedValue('#,##0_);(#,##0);', 0, 0)).toBe('')
|
||
})
|
||
|
||
it('hides every value under ;;;', () => {
|
||
expect(fixFormattedValue(';;;', 123, 123)).toBe('')
|
||
expect(fixFormattedValue(';;;', 'abc', 'abc')).toBe('')
|
||
})
|
||
|
||
it('leaves non-zero values on the normal sections', () => {
|
||
expect(fixFormattedValue('#,##0_);(#,##0);', 5, `5${NBSP}`.replace(NBSP, ' '))).toBe(`5${NBSP}`)
|
||
expect(fixFormattedValue('#,##0_);(#,##0);', -5, '(5)')).toBeNull()
|
||
})
|
||
})
|
||
|
||
describe('fixFormattedValue — _x padding and text section', () => {
|
||
it('upgrades trailing padding spaces to NBSP so layout keeps them', () => {
|
||
expect(fixFormattedValue('#,##0.0_);(#,##0.0)', 765.89, '765.9 ')).toBe(`765.9${NBSP}`)
|
||
})
|
||
|
||
it('pads the positive right edge by exactly one char (the width of `)`)', () => {
|
||
const pos = fixFormattedValue('#,##0.0_);(#,##0.0)', 765.89, '765.9 ') as string
|
||
expect(pos.endsWith(NBSP)).toBe(true)
|
||
expect(pos).toHaveLength('765.9'.length + 1)
|
||
})
|
||
|
||
it('applies the 4th (text) section to string cells', () => {
|
||
expect(fixFormattedValue('#,##0.0_);(#,##0.0);0.0_);@_)', 'abc', 'abc')).toBe(`abc${NBSP}`)
|
||
expect(
|
||
fixFormattedValue(
|
||
'#,##0.0_);(#,##0.0);0.0_);@_)',
|
||
'Training The Street',
|
||
'Training The Street',
|
||
),
|
||
).toBe(`Training The Street${NBSP}`)
|
||
})
|
||
|
||
it('leaves strings alone when the pattern has no text section', () => {
|
||
expect(fixFormattedValue('#,##0.0_);(#,##0.0)', 'abc', 'abc')).toBeNull()
|
||
})
|
||
|
||
it('restores numeric-looking text that Univer formatted as a number', () => {
|
||
// t="s" "9853" under a date format rendered 1926-12-22; Excel shows the
|
||
// text as-is (number formats apply to numbers only).
|
||
expect(fixFormattedValue('yyyy\\-mm\\-dd\\ hh:mm:ss', '9853', '1926-12-22 00:00:00')).toBe(
|
||
'9853',
|
||
)
|
||
expect(fixFormattedValue('0.00', '9853', '9853.00')).toBe('9853')
|
||
expect(fixFormattedValue('0.00', '9853', '9853')).toBeNull()
|
||
})
|
||
|
||
it('does not touch values Univer formatted with a different rendering', () => {
|
||
expect(fixFormattedValue('#,##0.0_);(#,##0.0)', 765.89, '765,9 ')).toBeNull()
|
||
})
|
||
})
|
||
|
||
describe('formatGeneral', () => {
|
||
it('shows 0.326883 at the default 8.43-char column width', () => {
|
||
// characterWidthToPixels(8.43) === 64
|
||
expect(generalCharBudget(64)).toBe(8)
|
||
expect(formatGeneral(0.326882822311, 8)).toBe('0.326883')
|
||
})
|
||
|
||
it('shows more digits as the column widens, capped at 11 significant', () => {
|
||
expect(formatGeneral(0.326882822311, 10)).toBe('0.32688282')
|
||
expect(formatGeneral(0.326882822311, 20)).toBe('0.326882822')
|
||
})
|
||
|
||
it('keeps short values untouched', () => {
|
||
expect(formatGeneral(123, 8)).toBe('123')
|
||
expect(formatGeneral(44562.5, 8)).toBe('44562.5')
|
||
expect(formatGeneral(0.5, 8)).toBe('0.5')
|
||
})
|
||
|
||
it('handles negatives (sign counts against the budget)', () => {
|
||
expect(formatGeneral(-0.326882822311, 8)).toBe('-0.32688')
|
||
})
|
||
|
||
it('switches to scientific when the integer part cannot fit', () => {
|
||
expect(formatGeneral(123456789012, 8)).toBe('1.23E+11')
|
||
expect(formatGeneral(1234567890123456, 20)).toBe('1.23457E+15')
|
||
// prod_039: 10-digit phone numbers in a built-in-width column.
|
||
expect(formatGeneral(7028015141, 8)).toBe('7.03E+09')
|
||
})
|
||
|
||
it('uses scientific for tiny fractions instead of rounding to 0', () => {
|
||
expect(formatGeneral(0.0000001234, 9)).toBe('1.234E-07')
|
||
expect(formatGeneral(0.0000001234, 8)).toBe('1.23E-07')
|
||
})
|
||
|
||
it('strips trailing zeros after shrinking', () => {
|
||
expect(formatGeneral(0.100000004, 8)).toBe('0.1')
|
||
})
|
||
|
||
it('never crashes on degenerate budgets', () => {
|
||
expect(generalCharBudget(0)).toBe(1)
|
||
expect(typeof formatGeneral(0.326882822311, 1)).toBe('string')
|
||
})
|
||
})
|
||
|
||
describe('decimal half-way rounding (Excel rounds the decimal literal)', () => {
|
||
it('rounds 1.005 up under 0.00 like Excel', () => {
|
||
expect(fixFormattedValue('0.00_ ', 1.005, `1.00${NBSP}`)).toBe(`1.01${NBSP}`)
|
||
})
|
||
|
||
it('leaves non-half-way values alone', () => {
|
||
expect(fixFormattedValue('0.00_ ', 1.004, `1.00${NBSP}`)).toBeNull()
|
||
expect(decimalRoundForPattern('0.00', 1.23)).toBe(1.23)
|
||
})
|
||
|
||
it('rounds negatives away from zero', () => {
|
||
expect(decimalRoundForPattern('0', -2.5)).toBe(-3)
|
||
expect(decimalRoundForPattern('0.00', -1.005)).toBe(-1.01)
|
||
})
|
||
|
||
it('pre-scales percent patterns', () => {
|
||
expect(decimalRoundForPattern('0.00%', 0.12345)).toBeCloseTo(0.1235, 10)
|
||
})
|
||
|
||
it('skips multi-section, date, fraction and scientific patterns', () => {
|
||
expect(decimalRoundForPattern('#,##0.0;(#,##0.00)', 1.005)).toBeNull()
|
||
expect(decimalRoundForPattern('yyyy-mm-dd', 1.005)).toBeNull()
|
||
expect(decimalRoundForPattern('# ?/?', 1.005)).toBeNull()
|
||
expect(decimalRoundForPattern('0.00E+00', 1.005)).toBeNull()
|
||
})
|
||
})
|