- **New app: GenOffice HTML.** Open, edit and generate .html pages: a source pane with a sandboxed live preview, click-to-select elements with a floating toolbar and style panel, device-size preview, image tools and a present mode. AI generates whole pages from a brief with style directions and offers page-wide Restyle, Theme and Summarize. Export to Word runs locally through the built-in html2docx converter (native, editable OOXML; no print-to-PDF detour). - **AI:** separate BYOK providers for web search, image generation and image/video analysis; new Codex App Server provider; Ask AI quotes the selected text and keeps it highlighted while it runs; custom AI panel text size; blocked requests retry through the Chromium network stack. - **App:** global AutoSave setting shared by every editor; AI panel text size and chat spellcheck toggles (genoffice#249); Czech (cs) UI locale (genoffice#259); Save As defaults to the document's folder; PDF export no longer aborts on CJK file paths on Windows. - **Docs:** Export as HTML; comments and replies edit in place from the comments pane; the caret can leave a trailing table (genoffice#266); spellcheck re-marks text as soon as it is re-enabled; AI edits are character-precise on partial selections; zoom keeps the scroll position; pasting a cell from Sheets takes the destination font. - **Sheets:** Find no longer freezes on wide or streamed grids; Replace searches as you type; cached values of external-workbook formulas are kept instead of #ERROR! (genoffice#235); "number stored as text" is a warning, not an error (genoffice#236); paste repeats into the target range like Excel; filter criteria survive save/reopen; saves retry when Windows locks the file; many Excel-fidelity fixes for column widths, row heights, charts, slicers, number formats and CJK fonts. - **Slides:** PDF export works for large presentations (genoffice#264); EMF/WMF picture fonts and East Asian theme fonts resolve correctly; decks with missing layouts or embedded styles still open; outline-only pie slices render. - **PDF:** highlight and underline geometry aligns with the text; Shift+arrows extend the selection instead of paging. - **Markdown:** Find and replace (Ctrl+F / Ctrl+H) (genoffice#253); mermaid code blocks render as diagrams (genoffice#263); better print quality. - Thanks to community contributors @GoodScholar, @aniruddhaadak80 and @Sun8854, and to @hanyscz, @qgzln, @zyp997, @bisslot, @krakotay and @Ben03151 for the reports. Co-authored-by: GenOffice <merrick-2002@users.noreply.github.com>
86 lines
2.8 KiB
TypeScript
86 lines
2.8 KiB
TypeScript
// Insert → Comment must start a new comment (not just toggle the pane), and it
|
|
// follows the Review-tab gate: live under the comments-only restriction, dead
|
|
// when a protection forbids commenting or there is nothing to anchor on.
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { act, createElement } from 'react'
|
|
import { createRoot, type Root } from 'react-dom/client'
|
|
import { Editor } from '@tiptap/core'
|
|
import { editorExtensions } from '../src/renderer/editor/extensions'
|
|
import { computeFormatState } from '../src/renderer/components/ribbon-format-state'
|
|
import { Ribbon } from '../src/renderer/components/Ribbon'
|
|
import { t } from '../src/renderer/i18n/locale'
|
|
import { ribbonProps } from './helpers/ribbon-props'
|
|
|
|
function makeEditor(): Editor {
|
|
return new Editor({
|
|
element: document.createElement('div'),
|
|
extensions: editorExtensions,
|
|
content: {
|
|
type: 'doc',
|
|
content: [{ type: 'docParagraph', content: [{ type: 'text', text: 'hello world' }] }],
|
|
},
|
|
})
|
|
}
|
|
|
|
describe('Insert → Comment', () => {
|
|
let editor: Editor
|
|
let root: Root
|
|
let container: HTMLElement
|
|
const onNewComment = vi.fn()
|
|
|
|
beforeEach(() => {
|
|
editor = makeEditor()
|
|
container = document.createElement('div')
|
|
document.body.appendChild(container)
|
|
root = createRoot(container)
|
|
})
|
|
|
|
afterEach(() => {
|
|
act(() => root.unmount())
|
|
container.remove()
|
|
editor.destroy()
|
|
onNewComment.mockClear()
|
|
})
|
|
|
|
function renderInsertTab(overrides: Record<string, unknown>) {
|
|
act(() =>
|
|
root.render(
|
|
createElement(Ribbon, {
|
|
...ribbonProps(editor, computeFormatState(editor)),
|
|
onNewComment,
|
|
...overrides,
|
|
}),
|
|
),
|
|
)
|
|
const insertTab = [...container.querySelectorAll<HTMLButtonElement>('.ribbon-tab')].find(
|
|
(b) => b.textContent === t('ribbonTabInsert'),
|
|
)!
|
|
act(() => insertTab.click())
|
|
return [...container.querySelectorAll<HTMLButtonElement>('button.rb-big')].find(
|
|
(b) => b.textContent === t('ribbonComment'),
|
|
)!
|
|
}
|
|
|
|
it('starts a new comment when an anchor is available', () => {
|
|
const btn = renderInsertTab({ canComment: true })
|
|
expect(btn.disabled).toBe(false)
|
|
act(() => btn.click())
|
|
expect(onNewComment).toHaveBeenCalledTimes(1)
|
|
})
|
|
|
|
it('is disabled with nothing to anchor on', () => {
|
|
const btn = renderInsertTab({ canComment: false })
|
|
expect(btn.disabled).toBe(true)
|
|
})
|
|
|
|
it('stays live under the comments-only restriction', () => {
|
|
const btn = renderInsertTab({ canComment: true, isProtected: true, commentsAllowed: true })
|
|
expect(btn.disabled).toBe(false)
|
|
})
|
|
|
|
it('is disabled when a protection forbids commenting', () => {
|
|
const btn = renderInsertTab({ canComment: true, isProtected: true, commentsAllowed: false })
|
|
expect(btn.disabled).toBe(true)
|
|
})
|
|
})
|